Skip to content

Fix top-level examples in push.go. #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix top-level examples in push.go. #1298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions prometheus/push/push.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
// by using its methods, finally calling Add or Push, like this:
//
// // Easy case:
// push.New("http://example.org/metrics", "my_job").Gatherer(myRegistry).Push()
// push.New("http://example.org/", "my_job").Gatherer(myRegistry).Push()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// push.New("http://example.org/", "my_job").Gatherer(myRegistry).Push()
// push.New("http://pushgateway.example.org", "my_job").Gatherer(myRegistry).Push()

//
// // Complex case:
// push.New("http://example.org/metrics", "my_job").
// push.New("http://example.org/", "my_job").
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// push.New("http://example.org/", "my_job").
// push.New("http://pushgateway.example.org", "my_job").

// Collector(myCollector1).
// Collector(myCollector2).
// Grouping("zone", "xy").
Expand Down