chore: refactor label parser #1032
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylvain Witmeyer <sylvain.witmeyer@gmail.com>
sylwit
force-pushed
the
feature/refactor_parser
branch
from
4023449 to
cc86745
Compare
sylwit
commented
May 13, 2024
| @@ -37,57 +37,29 @@ def _replace_escaping(s: str) -> str: | |||
| return ESCAPING_RE.sub(replace_escape_sequence, s) | |||
|
|
|||
|
|
|||
| def _is_character_escaped(s: str, charpos: int) -> bool: | |||
There was a problem hiding this comment.
this function is moved to openmetrics/parser.py
sylwit
force-pushed
the
feature/refactor_parser
branch
from
a84f6d3 to
7205ac5
Compare
Signed-off-by: Sylvain Witmeyer <sylvain.witmeyer@gmail.com>
sylwit
force-pushed
the
feature/refactor_parser
branch
from
7205ac5 to
139d601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor label parser to make it more readable and and faster