Update with more places for the http cache

psauthor · Jan 19, 2024 · 8a08b88 · 8a08b88
1 parent c0053e8
commit 8a08b88
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/src/Apis/EmployeesApi.cs b/src/Apis/EmployeesApi.cs
@@ -1,6 +1,7 @@
 using Asp.Versioning;
 using Mapster;
 using Marvin.Cache.Headers;
+using Marvin.Cache.Headers.Extensions;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.DependencyInjection;
@@ -26,16 +27,18 @@ public void Register(IEndpointRouteBuilder builder)
           description: "Employees of the company that can create time tickets."));
 
 
-    group.MapGet("", GetAll);
-    group.MapGet("{id:int}", GetOne).WithName("GetOneEmployee");
+    group.MapGet("", GetAll)
+      .AddHttpCacheExpiration(maxAge: 1, noStore: true);
+    group.MapGet("{id:int}", GetOne)
+      .WithName("GetOneEmployee")
+      .AddHttpCacheExpiration(maxAge: 1, noStore: true);
     group.MapPost("", Post);
     group.MapPut("{id:int}", Update);
     group.MapDelete("{id:int}", Delete);
 
   }
 
   // Get All
-  [HttpCacheExpiration(NoStore = true, MaxAge = 1)]
   public static async Task<IResult> GetAll(BillingContext ctx)
   {
     var result = await ctx.Employees
@@ -46,7 +49,6 @@ public static async Task<IResult> GetAll(BillingContext ctx)
   }
 
   // Get One
-  [HttpCacheExpiration(NoStore = true, MaxAge = 1)]
   public static async Task<IResult> GetOne(BillingContext ctx, int id)
   {
     var result = await ctx.Employees.FindAsync(id);

diff --git a/src/Apis/TicketsApi.cs b/src/Apis/TicketsApi.cs
@@ -1,6 +1,7 @@
 using Asp.Versioning;
 using Mapster;
 using Marvin.Cache.Headers;
+using Marvin.Cache.Headers.Extensions;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.DependencyInjection;
@@ -29,17 +30,16 @@ public void Register(IEndpointRouteBuilder builder)
 
     var theGet = group.MapGet("", GetAll);
 
-    group.MapGet("{id:int}", GetOne).WithName("GetOneTicket");
+    group.MapGet("{id:int}", GetOne).WithName("GetOneTicket")
+      .AddHttpCacheExpiration(cacheLocation: CacheLocation.Private, maxAge: 99999)
+      .AddHttpCacheValidation(mustRevalidate: true);
     group.MapPost("", Post);
     group.MapPut("{id:int}", Update);
     group.MapDelete("{id:int}", Delete);
 
   }
 
   // Get All
-  //[HttpCacheIgnore]
-  [HttpCacheExpiration(CacheLocation = CacheLocation.Private, MaxAge = 99999)]
-  [HttpCacheValidation(MustRevalidate = true)]
   public static async Task<IResult> GetAll(HttpContext http, 
     BillingContext ctx, 
     int page = 1,