Update with idempotency

psauthor · Jan 26, 2024 · e6d383c · e6d383c
1 parent 9e636a2
commit e6d383c
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 43 deletions.
diff --git a/src/Apis/CustomerProjectsApi.cs b/src/Apis/CustomerProjectsApi.cs
@@ -19,7 +19,7 @@ public void Register(IEndpointRouteBuilder builder)
         new SwaggerOperationAttribute(
           summary: "Customer's Projects",
           description: "Projects that are for a particular customer."));
-    
+
 
     group.MapGet("", GetAll);
     group.MapGet("{id:int}", GetOne).WithName("GetOneCustomerProject");
@@ -90,12 +90,9 @@ public static async Task<IResult> Update(BillingContext ctx, int customerId, int
 
       model.Adapt(old);
 
-      if (await ctx.SaveAllAsync())
-      {
-        return Results.Ok(old);
-      }
+      await ctx.SaveAllAsync();
 
-      return Results.BadRequest("Failed to save new Project.");
+      return Results.Ok(old);
     }
     catch (Exception ex)
     {

diff --git a/src/Apis/CustomersApi.cs b/src/Apis/CustomersApi.cs
@@ -90,12 +90,9 @@ public static async Task<IResult> Update(BillingContext ctx, int id, Customer mo
 
       model.Adapt(old);
 
-      if (await ctx.SaveAllAsync())
-      {
-        return Results.Ok(old);
-      }
+      await ctx.SaveAllAsync();
 
-      return Results.BadRequest("Failed to save new customer.");
+      return Results.Ok(old);
     }
     catch (Exception ex)
     {

diff --git a/src/Apis/EmployeesApi.cs b/src/Apis/EmployeesApi.cs
@@ -89,12 +89,8 @@ public static async Task<IResult> Update(BillingContext ctx, int id, Employee mo
 
       model.Adapt(old);
 
-      if (await ctx.SaveAllAsync())
-      {
-        return Results.Ok(old);
-      }
-
-      return Results.BadRequest("Failed to save new employee.");
+      await ctx.SaveAllAsync();
+      return Results.Ok(old);
     }
     catch (Exception ex)
     {

diff --git a/src/Apis/ProjectTicketsApi.cs b/src/Apis/ProjectTicketsApi.cs
@@ -99,18 +99,15 @@ public static async Task<IResult> Update(BillingContext ctx, int projectId, int
 
       model.Adapt(old);
 
-      if (await ctx.SaveAllAsync())
-      {
-        var result = await ctx.Tickets
-          .Include(t => t.Project)
-          .Include(t => t.Employee)
-          .Where(t => t.Id == model.Id && t.ProjectId == projectId)
-          .FirstAsync();
+      await ctx.SaveAllAsync();
 
-        return Results.Ok(result);
-      }
+      var result = await ctx.Tickets
+        .Include(t => t.Project)
+        .Include(t => t.Employee)
+        .Where(t => t.Id == model.Id && t.ProjectId == projectId)
+        .FirstAsync();
 
-      return Results.BadRequest("Failed to save new Ticket.");
+      return Results.Ok(result);
     }
     catch (Exception ex)
     {

diff --git a/src/Apis/ProjectsApi.cs b/src/Apis/ProjectsApi.cs
@@ -98,12 +98,8 @@ public static async Task<IResult> Update(BillingContext ctx, int id, Project mod
 
       model.Adapt(old);
 
-      if (await ctx.SaveAllAsync())
-      {
-        return Results.Ok(old);
-      }
-
-      return Results.BadRequest("Failed to save new Project.");
+      await ctx.SaveAllAsync();
+      return Results.Ok(old);
     }
     catch (Exception ex)
     {

diff --git a/src/Apis/TicketsApi.cs b/src/Apis/TicketsApi.cs
@@ -139,17 +139,12 @@ public static async Task<IResult> Update(BillingContext ctx, int id, Ticket mode
 
       model.Adapt(old);
 
-      if (await ctx.SaveAllAsync())
-      {
-        var result = await ctx.Tickets
-          .Include(t => t.Project)
-          .Include(t => t.Employee)
-          .Where(t => t.Id == model.Id).FirstAsync();
-
-        return Results.Ok(result);
-      }
+      var result = await ctx.Tickets
+        .Include(t => t.Project)
+        .Include(t => t.Employee)
+        .Where(t => t.Id == model.Id).FirstAsync();
 
-      return Results.BadRequest("Failed to save new Ticket.");
+      return Results.Ok(result);
     }
     catch (Exception ex)
     {