Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Manual V2 Skeleton #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Launch Manual V2 Skeleton #172
Changes from 3 commits
26bcc95
7f95b6c
077ff90
93ba224
72b8c30
936d70d
2aba647
310da84
dc789fc
308028d
dece773
6a59cba
b87a9d0
d4699f9
b8bb671
0d212bc
fbc0c69
b8fcb8e
0e9af20
947fae6
58ce937
35ad982
fd7758f
a5b7b64
edce353
ba84d97
f51d4bd
913b4ac
0f4803b
8ed0b64
d7eb53e
c304afa
4763393
1a733ed
1f1eb16
ece7baf
1556307
96a558e
2fd2e26
34ec523
18730d4
4d67fcb
ee57d91
62d4bb7
e4889b1
24b85cd
2f3ff48
f258bd5
8026838
4ea85ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general comment about this document:
We are now encouraging people to use
pulsar -p
instead ofppm
, but we still have a need to refer to “PPM” as a concept. The concept is the suite of tools responsible for downloading, installing, developing, and publishing Pulsar packages.Hence all the references to “PPM” in the docs. I have corrected most of these to
ppm
, which I understand is troublesome because — again — we want people to start typingpulsar -p
. But if we do that, I think it's likely that a new user will fail to understand what we mean when we say “PPM.”Maybe this is a hint about how to proceed. I know that if
ppm
were ever to stop existing as a tool, I'd justalias ppm="pulsar -p"
in my.zshrc
and proceed as before. Maybe there's still value in the idea of a separate binary, even if all it does internally is callpulsar -p
.This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh idk what exactly the update is. patch, minor, or major, or is this about the database somehow?
Edit: Oh this is answered below. This isn't really a review since it comes before the information. Maybe replace with a summary, or move after the info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reminds me of this one rust comment. maybe this formulation is simpler:
major - upgrading breaks
minor - downgrading breaks
patch - neither
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While that might be a bit simpler, the text taken here iirc is taken directly from the SEMVER docs, and is what we currently use.
But as we do already link to the semver docs maybe we can take the opportunity to make this a bit simpler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this formulation isn't exactly the same as semver but it does make things clearer I think...
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.