Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some Module examples #799

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

karpfediem
Copy link
Contributor

@karpfediem karpfediem commented Mar 11, 2025

I will be adding some more example modules here that I am using, which I can share.

This is a Work In Progress for now and I'm happy to improve upon these.

The changes of this MR should remain limited to the modules/ directory.

@karpfediem karpfediem force-pushed the feature/module_examples branch from 46d9e08 to 9db644c Compare March 11, 2025 15:04
@purpleidea
Copy link
Owner

Nice! If you want to rename the bash commit properly, I could cherry-pick/merge that one.

For the mcl stuff, needs tabs instead of spaces.

@karpfediem karpfediem force-pushed the feature/module_examples branch 4 times, most recently from d6f782d to 675e3a5 Compare March 16, 2025 19:38
@karpfediem
Copy link
Contributor Author

Making tests work properly under NixOS took me a bit longer than anticipated.
I will add module descriptions soon, but at another time.

@purpleidea
Copy link
Owner

Overall the whole thing fails, but if the shebang commits and other bits are ready to be cherry-picked, maybe put those in a separate PR so I can see it passes and I can pull those in early.

@purpleidea
Copy link
Owner

(Doesn't need to pass the race tests, just the basic and shell.)

@karpfediem
Copy link
Contributor Author

karpfediem commented Mar 16, 2025

Overall the whole thing fails, but if the shebang commits and other bits are ready to be cherry-picked, maybe put those in a separate PR so I can see it passes and I can pull those in early.

Sorry, but i think it's not ready yet afterall. There are many more cases of FHS filepaths.
For now i have fixed my own issues using a shell with emulated FHS paths.
I would like to rather address it all at the same time in a separate issue after giving it some more thought.

EDIT: split some of it out into #801 and #802

@purpleidea
Copy link
Owner

FYI: I cherry-picked/merged/etc most of this. You may wish to rebase at some point or open a new PR.

@karpfediem karpfediem force-pushed the feature/module_examples branch from 8a097a9 to d6c0127 Compare March 23, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants