-
Notifications
You must be signed in to change notification settings - Fork 19
Add the total amount of hours for visible timespan to order_plannings (63115) #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add the total amount of hours for visible timespan to order_plannings (63115) #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite unsurprisingly, I want to see tests, at least for the change to the domain-class. Bonus for controller-tests that check if some expected strings are where they are expected.
cc7045a
to
16622f8
Compare
Co-authored-by: Matthias Viehweger <kronn@kronn.de>
…g to specify if we only want the hours for the active period, or for any time)
ad55e56
to
4574709
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @svenwey
I just found out that I can make the total disappear:
disappearing_total.webm
disappearing_total.mp4
After a reload, it's shown again.
Otherwise this looks good.
Hey @Kagemaru I think I can't view the file. Would it maybe be possible to share it again? |
I've now added it to the last post as .mp4 too. |
Perfect. I'll take a look at it. |
This change adds an additional column with the total amount of hours in the visible/selected timespan in order_plannings (per member & total). Slightly alters the styling to accommodate these changes.