fix: fire and forget update tx #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
approved these changes
Dec 14, 2023
ali-bahjati
force-pushed
the
fix/fire-and-forget-updates
branch
from
d8a290b to
6872b52
Compare
The old behaviour causes the exporter not to publishing prices regularly. This change spawns a separate thread to unblock the exporter loop. Also, because of the batch staggering behaviour to avoid calling rpc for all batches at the same time, the old approach would always results in waiting longer than the publishing period.
ali-bahjati
force-pushed
the
fix/fire-and-forget-updates
branch
from
6872b52 to
9e09a57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old behaviour causes the exporter not to publish prices regularly. This change spawns a separate thread to unblock the exporter loop on the rpc send_tx call. Also, because of the batch staggering behaviour to avoid calling rpc for all batches at the same time, the old approach would always resulted in waiting longer than the publishing period.