refactor(agent): various refactors #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-bahjati
reviewed
Jun 5, 2024
ali-bahjati
reviewed
Jun 5, 2024
Reisen
force-pushed
the
push-ymommvsnryks
branch
2 times, most recently
from
c93bcf5 to
a8ccdab
Compare
| pub fn default_bind_address() -> SocketAddr { | ||
| "127.0.0.1:9001" | ||
| .parse() | ||
| .expect("INTERNAL: Could not build default remote keypair loader bind address") |
There was a problem hiding this comment.
I know you probably just copied this. IMO it's better to just do .unwrap for the statics that we know exactly what it is and it will never fail.
Comment on lines
+209
to
+210
| /// NOTE(2023-03-22): Lifetime bounds are currently necessary | ||
| /// because of https://github.com/rust-lang/rust/issues/63033 |
There was a problem hiding this comment.
I think this issue is now resolved, we might need to update rust tho. Maybe we can fix this in a future refactor PR.
ali-bahjati
approved these changes
Jun 5, 2024
The StateApi is left over from the initial Adapter, but all functionality is for pricing/product accounts. This refactors that module and fixes the cyclic dependency between it and GlobalStore. The new logic performs updates within the Prices API (Which is where the state relevant to subscriptions already was, so is the better place for it). File rename left for a future commit to keep the diffs clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several refactors, each commit is self-contained and should be reviewed individually. You can leave comments directly on the commits. See the commit messages which might contain more information about a specific refactor.
Follow-up to: