feat(apps/hermes): new client package for hermes #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
cctdaniel
commented
Jun 4, 2024
ali-bahjati
reviewed
Jun 5, 2024
cprussin
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Most of my comments are just little suggestions and not super important.
IMO the most important thing is I strongly, strongly recommend using a runtime schema validator rather than relying on generated types and unsafe casting.
Feel free to disregard the other comments as you feel it makes sense. Happy to expand on anything if it helps, a lot of this is somewhat esoteric knowledge I've picked up over the years and have become opinionated on but of course other opinions are valid too.
cprussin
reviewed
Jun 5, 2024
cprussin
reviewed
Jun 6, 2024
cprussin
reviewed
Jun 6, 2024
ali-bahjati
reviewed
Jun 7, 2024
ali-bahjati
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zodfor schema validationserverfolder inapps/hermesoracle-swapandsend-usdexample since they are moved to https://github.com/pyth-network/pyth-exampleswill deprecate
price-service-clientonce this package is published