-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lazer): add fees to solana contract #2146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Riateche
force-pushed
the
lazer-solana-fees
branch
from
November 27, 2024 11:18
bcb5550
to
166386b
Compare
Riateche
force-pushed
the
lazer-solana-fees
branch
from
November 27, 2024 11:36
166386b
to
be3e12c
Compare
ali-bahjati
reviewed
Nov 28, 2024
lazer/contracts/solana/programs/pyth-lazer-solana-contract/src/lib.rs
Outdated
Show resolved
Hide resolved
Riateche
force-pushed
the
lazer-solana-fees
branch
from
November 29, 2024 14:21
0ee1df5
to
064db89
Compare
ali-bahjati
reviewed
Nov 29, 2024
lazer/contracts/solana/programs/pyth-lazer-solana-contract/src/lib.rs
Outdated
Show resolved
Hide resolved
ali-bahjati
approved these changes
Nov 29, 2024
Riateche
force-pushed
the
lazer-solana-fees
branch
from
December 3, 2024 14:24
1ceb2ed
to
87f7828
Compare
ali-bahjati
approved these changes
Dec 3, 2024
keyvankhademi
approved these changes
Dec 4, 2024
cprussin
pushed a commit
to cprussin/pyth-crosschain
that referenced
this pull request
Dec 4, 2024
* refactor(lazer): change verify_message to a contract call, add test * feat(lazer): add treasury and fees to solana contract * feat(lazer): make treasury configurable, add migration * feat(lazer): add extra space to contract's pda * fix(lazer): keep old names for legacy structs for compatibility * refactor(lazer): keep good names for new types and methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user will now call our contract so that we can withdraw fees to the treasury account.
Not sure about the migration path for devnet/testnet. We can redeploy the program itself but the storage account also needs to be migrated somehow.