Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Solana SDK README #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Simplify Solana SDK README #48

wants to merge 2 commits into from

Conversation

tompntn
Copy link
Contributor

@tompntn tompntn commented Apr 28, 2022

This PR removes the description of the account structure, which is an implementation detail, and adds a link to the pyth.network docs which explain how to look up the price feed IDs.

Eventually the website will show a definitive list of price feed IDs for each blockchain, but in the meantime this should be documented.

@tompntn tompntn requested review from ali-bahjati and jayantk April 28, 2022 12:56
Copy link
Collaborator

@ali-bahjati ali-bahjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simpler the better! tyvm!

Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to leave the low-level API in the readme. It's useful for some people who want to e.g., iterate over the products in Pyth. This documentation has an appropriate warning as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants