Skip to content

WIP: replace BlockingRunner with AsyncRunner + asyncio.run #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

WIP: replace BlockingRunner with AsyncRunner + asyncio.run #230

wants to merge 3 commits into from

Conversation

jbweston
Copy link
Contributor

This eliminates a lot of code duplication.
We also deprecate the use of BlockingRunner directly.

@jbweston
replace BlockingRunner with AsyncRunner + asyncio.run
bcce75f 
This eliminates a lot of code duplication.
We also deprecate the use of BlockingRunner directly.
basnijholt
basnijholt reviewed Nov 28, 2019
View reviewed changes
@jbweston
Copy link
Contributor Author

jbweston commented Nov 28, 2019 •
edited
Loading

TODO

  • use the deprecated sphinx directive in docstrings
  • replaces uses of BlockingRunner in the documentation with Runner + asyncio.run

jbweston
jbweston commented Dec 17, 2019
View reviewed changes
@jbweston
remove use of asyncio.run
c16e40f 
This is a Python 3.7 feature, and in addition cannot be used with asyncio *tasks* (only coroutines).
@jbweston
correct docstring
19f7992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basnijholt basnijholt basnijholt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbweston @basnijholt