Fix WebSocket import error for Python 3.12 compatibility #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The solution should also be backwards compatible with other supported versions of python |
|
It verry good |
|
@samuelhwilliams Can you please have a look at pulling this in for 3.12 support |
samuelhwilliams
force-pushed
the
bottle-websocket-fix
branch
from
f610fab to
739f6a4
Compare
|
Thanks for the nudge and sorry for the delay. This looks good - will merge. |
This was referenced Jul 11, 2024
|
Thanks Samuel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue encountered specifically in Python 3.12 related to importing the WebSocket extension in Bottle applications. The error arises due to the absence of the bottle.ext.websocket
Additionally I added tox configurations for Python 3.11 and Python 3.12
This PR should also resolve the following issues:
#723