fix: allow 'Content-Length' = "0" #1617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bonjour @aaugustin Any feedback on this PR? |
|
I'll take care of it. |
JohnVillalovos
force-pushed
the
jlvillal/shelly_fix
branch
from
47d294f to
5482e10
Compare
Shelly devices send a 'Content-Length' header with a value of "0". Allow this as this also means there is not a request body. In addition give a bit more detail in the error message. Closes: #1616
JohnVillalovos
force-pushed
the
jlvillal/shelly_fix
branch
from
5482e10 to
ecd7250
Compare
Thanks. I believe I have resolved the CI issues. I also added and updated the unit tests. |
|
Thank you! |
My pleasure 🙂 |
aaugustin
added a commit
that referenced
this pull request
Apr 12, 2025
(Mostly a matter of taste.) Refs #1617.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shelly devices send a 'Content-Length' header with a value of "0". Allow this as this also means there is not a request body.
In addition give a bit more detail in the error message.
Closes: #1616