Remove some dead code from gzip and tarfile
#138123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
StanFromIreland
added
skip issue
skip news
type-refactor
serhiy-storchaka
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
LGTM. 👍
original_n was added in b5a6db9 and was never used. It looks unrelated to that change.
writebuf and bufsize were in Lib/gzip.py from beginning, but they were never used. This is the only occurrence of writebuf in the stdlib, so it is unlikely they were added for use outside of the gzip module. The bufsize attribute is defined in some classes, but it is always used in the same class, nothing related to gzip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed these, while taking a look at gh-138117.
I don't think it warrants a blurb, nor an issue.