Skip to content

gh-138061: Exclude __pycache__ directory from the computed digest in the jit stencils #138131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-138061: Exclude __pycache__ directory from the computed digest in the jit stencils #138131

wants to merge 4 commits into from
+4 −0

Conversation

alonme
Copy link
Contributor

@alonme alonme commented Aug 25, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Aug 25, 2025
Open
alonme
alonme commented Aug 25, 2025
View reviewed changes
diegorusso
diegorusso approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@diegorusso diegorusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM but I'd like a second opinion on it.

@diegorusso
Copy link
Contributor

I'm also 50/50 for the news file. Let's wait a second opinion.

@bmwiedemann
Copy link
Contributor

I tested this change and it helped.

@diegorusso diegorusso changed the title gh-138061: Exclude .pyc files from the computed digest in the jit stencils gh-138061: Exclude __pycache__ directory from the computed digest in the jit stencils Aug 27, 2025
@diegorusso
Copy link
Contributor

Ok, let's try to progress this. Can you create a news file? Click on bedevere/news in the failed checks and follow the instructions. Focus more on the purpose of the PR from the user point of view.

@alonme
Copy link
Contributor Author

alonme commented Aug 28, 2025

@diegorusso Thanks for reviews,
Are we still waiting for another reviewer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegorusso diegorusso diegorusso approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

randomness in jit_stencils.h
3 participants
@alonme @diegorusso @bmwiedemann