[mypyc] Fix incref/decref on free-threaded builds #19127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix C compile errors on free-threaded builds. We can't (easily) access the reference count value directly, so always use the C API functions when on a free-threaded build.
jhance
reviewed
May 27, 2025
| @@ -31,6 +31,8 @@ | |||
| // Here just for consistency | |||
| #define CPy_XDECREF(p) Py_XDECREF(p) | |||
|
|
|||
| #ifndef Py_GIL_DISABLED | |||
|
|
|||
| // The *_NO_IMM operations below perform refcount manipulation for | |||
There was a problem hiding this comment.
Can you adjust this comment to mention something like "this optimization cannot be performed with free threaded mode so we fallback to just calling the normal decref.
jhance
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix C compile errors on free-threaded builds. We can't (easily) access the reference count value directly, so always use the C API functions when on a free-threaded build.
Work on mypyc/mypyc#1038.