-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
bump fractions.pyi to 3.14 #14070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump fractions.pyi to 3.14 #14070
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
@sobolevn can you please take a look? |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update https://github.com/python/typeshed/blob/main/stdlib/%40tests/test_cases/builtins/check_pow.py when adding new __pow__
overloads. Basically, any non-None
modulo
values must be a type-error, see python/cpython@fcca08e#diff-39381000227588e760871a319e6b5f8e88fc03643b03a94acd2e94b942135e9b
For |
Thanks, I didn't get it quickly :) will add tests |
@sobolevn, okay, but what about these tests? aren't they enough? typeshed/stdlib/@tests/test_cases/builtins/check_pow.py Lines 52 to 53 in 1063db7
|
This comment has been minimized.
This comment has been minimized.
@sobolevn and also here additional check for non-None value of modulo
|
@mkaraev could you resolve conflicts? ( |
@donBarbos, sure, I will updatethe PR soon |
8095dbc
to
c4d963f
Compare
This PR has become old. Maybe we need a new one from the main branch. |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
No description provided.