start fixing issue 14168 with TarFile #14172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
May 27, 2025
stdlib/tarfile.pyi
Outdated
| @overload | ||
| def __init__( # noqa: F811 | ||
| self, | ||
| name: StrOrBytesPath | None, |
There was a problem hiding this comment.
Suggested change
| name: StrOrBytesPath | None, | |
| name: StrOrBytesPath, |
| @overload | ||
| def __init__( | ||
| self, | ||
| fileobj: _Fileobj, |
There was a problem hiding this comment.
Suggested change
| fileobj: _Fileobj, | |
| fileobj: _Fileobj, | |
| *, |
stdlib/tarfile.pyi
Outdated
| @overload | ||
| def __init__( # noqa: F811 | ||
| self, | ||
| name: StrOrBytesPath | None, |
There was a problem hiding this comment.
Suggested change
| name: StrOrBytesPath | None, | |
| name: StrOrBytesPath, |
| ) -> None: ... | ||
| def __init__( | ||
| self, | ||
| fileobj: _Fileobj, |
There was a problem hiding this comment.
Suggested change
| fileobj: _Fileobj, | |
| fileobj: _Fileobj, | |
| *, |
|
Thanks for this! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This is already done? |
This comment has been minimized.
This comment has been minimized.
|
All the failed tests don't seem to apply to my changes and to the TarFile. Otherwise, everything should work. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is my first PR, please sorry if this not solving issue. Please, if something is wrong, write. I'm just starting this exciting journey in contributing.