Skip to content

feat: Add support for Groot N1.5 model #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 25, 2025
Merged

feat: Add support for Groot N1.5 model #3736

merged 6 commits into from
Aug 25, 2025

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Jul 31, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@peri044
feat: Add support for Groot N1.5 model
5f34cfd 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@meta-cla meta-cla bot added the cla signed label Jul 31, 2025
@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jul 31, 2025
@github-actions github-actions bot requested a review from gs-olive July 31, 2025 14:43
@peri044 peri044 marked this pull request as draft July 31, 2025 14:43
@peri044 peri044 requested review from narendasan and removed request for gs-olive July 31, 2025 14:44
narendasan
narendasan approved these changes Aug 19, 2025
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems mostly good to go to me

py/torch_tensorrt/dynamo/conversion/impl/matmul.py
_enums.dtype._from(input.dtype).to(torch.dtype),
_enums.dtype._from(other.dtype).to(torch.dtype),
)
if (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we start noting down these specific type behavior things somewhere, like in the contributor docs?

@peri044 peri044 marked this pull request as ready for review August 20, 2025 18:43
peri044 added 2 commits August 20, 2025 11:45
@peri044
chore: rebase with main
3511e54 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: update docs
edce4b4 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 21, 2025
@peri044
chore: Remove the test case
763fd08 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@github-actions github-actions bot added the component: tests Issues re: Tests label Aug 25, 2025
@peri044 peri044 merged commit 91bb090 into main Aug 25, 2025
79 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: runtime component: tests Issues re: Tests documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peri044 @narendasan