Skip to content

pass compilation; fail linking to lib/libc10d.a #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pass compilation; fail linking to lib/libc10d.a #1341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions cpp/distributed/dist-mnist.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
#include <c10d/ProcessGroupMPI.hpp>
#define USE_C10D_MPI
#include <torch/csrc/distributed/c10d/Work.hpp>
#include <torch/csrc/distributed/c10d/ProcessGroup.hpp>
#include <torch/csrc/distributed/c10d/ProcessGroupMPI.hpp>
#include <torch/torch.h>
#include <iostream>

Expand Down Expand Up @@ -35,8 +38,8 @@ struct Model : torch::nn::Module {
};

void waitWork(
std::shared_ptr<c10d::ProcessGroupMPI> pg,
std::vector<std::shared_ptr<c10d::ProcessGroup::Work>> works) {
c10::intrusive_ptr<c10d::ProcessGroupMPI> pg,
std::vector<c10::intrusive_ptr<c10d::Work>> works) {
for (auto& work : works) {
try {
work->wait();
Expand Down Expand Up @@ -115,7 +118,7 @@ int main(int argc, char* argv[]) {
// since this synchronizes parameters after backward pass while DDP
// overlaps synchronizing parameters and computing gradients in backward
// pass
std::vector<std::shared_ptr<::c10d::ProcessGroup::Work>> works;
std::vector<::c10::intrusive_ptr<::c10d::Work>> works;
for (auto& param : model->named_parameters()) {
std::vector<torch::Tensor> tmp = {param.value().grad()};
auto work = pg->allreduce(tmp);
Expand Down