Override unload_method in training_module to erase the tensors pointing to the released memory #13590

silverguo · 2025-08-21T23:25:18Z

Summary: as title

Differential Revision: D80754181

pytorch-bot · 2025-08-21T23:25:22Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13590

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit dd38733 with merge base 52128bd ():

NEW FAILURE - The following job has failed:

Build documentation / build (buck2) / Build doc (gh)
At least one of the pre-conditions you specified did not hold

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / macos / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
pull / unittest-editable / macos / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-08-21T23:25:27Z

This pull request was exported from Phabricator. Differential Revision: D80754181

github-actions · 2025-08-21T23:25:57Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…ng to the released memory (pytorch#13590) Summary: as title Differential Revision: D80754181

facebook-github-bot · 2025-08-22T00:01:41Z

This pull request was exported from Phabricator. Differential Revision: D80754181

…ng to the released memory (pytorch#13590) Summary: as title Differential Revision: D80754181

facebook-github-bot · 2025-08-22T22:20:23Z

This pull request was exported from Phabricator. Differential Revision: D80754181

JacobSzwejbka · 2025-08-24T06:43:59Z

extension/training/module/training_module.h

+    return methods_.erase(method_name);
+  }
+
+  inline bool unload_forward() {


Nit: I expect this is an uncommon operation so don't need this.

JacobSzwejbka · 2025-08-24T06:44:18Z

extension/training/module/training_module.h

@@ -49,6 +49,19 @@ class ET_EXPERIMENTAL TrainingModule final
  explicit TrainingModule(Module&&) = delete;
  TrainingModule& operator=(Module&&) = delete;

+  // Overriding to erase the tensors pointing to the released memory.


It's not overriding

…ng to the released memory (pytorch#13590) Summary: as title Differential Revision: D80754181

facebook-github-bot · 2025-08-25T17:02:15Z

This pull request was exported from Phabricator. Differential Revision: D80754181

facebook-github-bot · 2025-08-25T17:17:23Z

This pull request was exported from Phabricator. Differential Revision: D80754181

…ng to the released memory (pytorch#13590) Summary: Pull Request resolved: pytorch#13590 as title Differential Revision: D80754181

…ng to the released memory (pytorch#13590) Summary: as title Differential Revision: D80754181

facebook-github-bot · 2025-08-25T17:33:18Z

This pull request was exported from Phabricator. Differential Revision: D80754181

…ng to the released memory (pytorch#13590) Summary: as title Differential Revision: D80754181

…ng to the released memory (pytorch#13590) Summary: as title Reviewed By: JacobSzwejbka Differential Revision: D80754181

facebook-github-bot · 2025-08-26T01:48:35Z

This pull request was exported from Phabricator. Differential Revision: D80754181

silverguo requested a review from JacobSzwejbka as a code owner August 21, 2025 23:25

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2025

facebook-github-bot added the fb-exported label Aug 21, 2025

silverguo added a commit to silverguo/executorch that referenced this pull request Aug 22, 2025

Override unload_method in training_module to erase the tensors pointi…

ae89bc8

…ng to the released memory (pytorch#13590) Summary: as title Differential Revision: D80754181

silverguo force-pushed the export-D80754181 branch from af8920e to ae89bc8 Compare August 22, 2025 00:01

silverguo force-pushed the export-D80754181 branch from ae89bc8 to 9413559 Compare August 22, 2025 22:20

silverguo added a commit to silverguo/executorch that referenced this pull request Aug 22, 2025

Override unload_method in training_module to erase the tensors pointi…

9413559

…ng to the released memory (pytorch#13590) Summary: as title Differential Revision: D80754181

JacobSzwejbka reviewed Aug 24, 2025

View reviewed changes

silverguo force-pushed the export-D80754181 branch from 9413559 to 6ed1e69 Compare August 25, 2025 17:00

silverguo added a commit to silverguo/executorch that referenced this pull request Aug 25, 2025

Override unload_method in training_module to erase the tensors pointi…

6ed1e69

…ng to the released memory (pytorch#13590) Summary: as title Differential Revision: D80754181

silverguo added a commit to silverguo/executorch that referenced this pull request Aug 25, 2025

Override unload_method in training_module to erase the tensors pointi…

7c29ee9

…ng to the released memory (pytorch#13590) Summary: as title Differential Revision: D80754181

silverguo force-pushed the export-D80754181 branch from 6ed1e69 to 7c29ee9 Compare August 25, 2025 17:02

silverguo force-pushed the export-D80754181 branch from 7c29ee9 to a1ff156 Compare August 25, 2025 17:17

silverguo added a commit to silverguo/executorch that referenced this pull request Aug 25, 2025

Override unload_method in training_module to erase the tensors pointi…

09baae4

…ng to the released memory (pytorch#13590) Summary: as title Differential Revision: D80754181

silverguo force-pushed the export-D80754181 branch from a1ff156 to 09baae4 Compare August 25, 2025 17:33

JacobSzwejbka approved these changes Aug 25, 2025

View reviewed changes

silverguo added a commit to silverguo/executorch that referenced this pull request Aug 25, 2025

Override unload_method in training_module to erase the tensors pointi…

9d7a0f7

…ng to the released memory (pytorch#13590) Summary: as title Differential Revision: D80754181

silverguo force-pushed the export-D80754181 branch from 2fa2d48 to 9d7a0f7 Compare August 25, 2025 21:52

Redefine unload_method in training_module to erase the tensors pointi…

dd38733

…ng to the released memory (pytorch#13590) Summary: as title Reviewed By: JacobSzwejbka Differential Revision: D80754181

silverguo force-pushed the export-D80754181 branch from 9d7a0f7 to dd38733 Compare August 26, 2025 01:48

facebook-github-bot merged commit 7dab7c1 into pytorch:main Aug 26, 2025
108 of 112 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Override unload_method in training_module to erase the tensors pointing to the released memory #13590

Override unload_method in training_module to erase the tensors pointing to the released memory #13590

silverguo commented Aug 21, 2025

Uh oh!

pytorch-bot bot commented Aug 21, 2025 •

edited

Loading

Uh oh!

facebook-github-bot commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

facebook-github-bot commented Aug 22, 2025

Uh oh!

facebook-github-bot commented Aug 22, 2025

Uh oh!

JacobSzwejbka Aug 24, 2025

Uh oh!

JacobSzwejbka Aug 24, 2025

Uh oh!

facebook-github-bot commented Aug 25, 2025

Uh oh!

facebook-github-bot commented Aug 25, 2025

Uh oh!

facebook-github-bot commented Aug 25, 2025

Uh oh!

facebook-github-bot commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

Override unload_method in training_module to erase the tensors pointing to the released memory #13590

Override unload_method in training_module to erase the tensors pointing to the released memory #13590

Conversation

silverguo commented Aug 21, 2025

Uh oh!

pytorch-bot bot commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13590

❌ 1 New Failure, 2 Unrelated Failures

Uh oh!

facebook-github-bot commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Aug 22, 2025

Uh oh!

facebook-github-bot commented Aug 22, 2025

Uh oh!

JacobSzwejbka Aug 24, 2025

Choose a reason for hiding this comment

Uh oh!

JacobSzwejbka Aug 24, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Aug 25, 2025

Uh oh!

facebook-github-bot commented Aug 25, 2025

Uh oh!

facebook-github-bot commented Aug 25, 2025

Uh oh!

facebook-github-bot commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 21, 2025 •

edited

Loading

This PR needs a `release notes:` label