-
Notifications
You must be signed in to change notification settings - Fork 649
Update coremltools to 9b1 #13614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update coremltools to 9b1 #13614
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13614
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 440b14e with merge base 3db27cd ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
@@ -47,26 +44,6 @@ def split_copy(context, node): | |||
split(context, node) | |||
|
|||
|
|||
@register_torch_op( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This op was added to coremltools 9.0, so we no longer need to register it in ET
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the failing unit tests are being the version of this op in coremltools 9.0 is not being lowered correctly, so we might need to ET version still. Will investigate further.
@metascroy has imported this pull request. If you are a Meta employee, you can view this in D80886500. |
This updates main to use coremltools 9.0b1.
We will pin the ExecuTorch GA release to use the official coremltools 9.0 release when it comes out.