Skip to content

Fix prefetch train pipeline #3306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peterfu0
Copy link

Summary:
there are 2 bugs

  • a random stream is used as default stream
  • prefetch stream is not waited by pipelined_forward

Rollback Plan:

Differential Revision: D80268824

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80268824

peterfu0 added a commit to peterfu0/torchrec that referenced this pull request Aug 21, 2025
Summary:

there are 2 bugs
* a random stream is used as default stream
* prefetch stream is not waited by pipelined_forward

Differential Revision: D80268824
Summary:
Pull Request resolved: pytorch#3306

there are 2 bugs
* a random stream is used as default stream
* prefetch stream is not waited by pipelined_forward

Differential Revision: D80268824
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80268824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants