-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 0.6rc1 release #216
Conversation
@CSSFrancis, I listed you as a maintainer alongside Duncan, Phillip, and myself in the release info. Which I thought you already were. I hope this is OK? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CSSFrancis, I listed you as a maintainer alongside Duncan, Phillip, and myself in the release info. Which I thought you already were. I hope this is OK?
That's probably fine. I haven't really done much with diffsims
until recently so it makes sense, I was planning on doing some more in the next couple of months.
As far as the PR goes I looked through all of the changes and it looks good to me
Great and great! Thanks for looking it over. We should be good to merge and release once your doc examples PR is in. |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…tice Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
c3cb8ac
to
5bbd6f2
Compare
Description of the change
Release prep:
Other changes:
StructureLibrary.from_crystal_systems()
. The method previously threw a NotImplementedError, but will now throw an AttributeError. Mentioned in the changelog under Removed.Rotation.from_neo_euler()
withRotation.from_axes_angles()
.I've cleaned up the test suite a bit:
xfail(error)
withwith pytest.raises(error):
. To me, it seems like best practice is to use the latter when we intentionally raise errors in the code, while the former is mostly used as a temporary measure for bugs that will be fixed.plt.close()
(silencing a warning of > 20 open plots from Matplotlib)Progress of the PR
For reviewers
__init__.py
.unreleased section in
CHANGELOG.rst
.credits
indiffsims/release_info.py
andin
.zenodo.json
.