Rpc add options for bridge #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for quackduck#248
protoc --go_out=.. --go-grpc_out=.. plugin/plugin.proto
This is needed for quackduck#248
protoc --go_out=.. --go-grpc_out=.. plugin/plugin.proto
…pc-add-options-for-bridge
Arkaeriit
reviewed
Mar 7, 2025
Arkaeriit
reviewed
Mar 7, 2025
|
Looks rather good to me. What did you do for testing? |
|
I tested the the example plugin and made a simple plugin to just print the outputs into the terminal to test the two new parameters |
Arkaeriit
reviewed
Mar 11, 2025
Update dependencies
|
Just rebase your MR on master so the dependencies updates are not duplicated and this will be ready to be merged. |
This is needed for quackduck#248
protoc --go_out=.. --go-grpc_out=.. plugin/plugin.proto
|
pr with git fixed #253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a backwards compatible rpc update that enables plugins to get user color and system messages. This is usefully especially for bridges and similar