Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify synonyms #355

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Simplify synonyms #355

merged 6 commits into from
Dec 20, 2024

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Dec 18, 2024

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to QuantumToolbox.jl.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

As title

Related issues or PRs

closes #354

@ytdHuang ytdHuang added the Skip ChangeLog Skip changelog update check in PR label Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (ade8b45) to head (d31a482).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   93.18%   93.14%   -0.05%     
==========================================
  Files          41       41              
  Lines        2700     2684      -16     
==========================================
- Hits         2516     2500      -16     
  Misses        184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang
Copy link
Member Author

ytdHuang commented Dec 18, 2024

@albertomercurio

The similar code quality error is showing again, but this time is related to ssesolve (last time was sesolve)...

Do you have any idea @@?

@albertomercurio
Copy link
Member

Mmmm. Let me try a few things.

@ytdHuang
Copy link
Member Author

Would it be related to the c_ops ?
cause the type of c_ops seems unclear in making H_eff_evo

@albertomercurio albertomercurio merged commit 270d3f6 into qutip:main Dec 20, 2024
16 of 17 checks passed
@ytdHuang ytdHuang deleted the opt/synonyms branch December 20, 2024 23:43
labay11 pushed a commit to labay11/QuantumToolbox.jl that referenced this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip ChangeLog Skip changelog update check in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify synonyms
2 participants