Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first try of Space and Dimensions #359

Merged
merged 15 commits into from
Jan 1, 2025
Merged

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Dec 24, 2024

Description

Just make a draft PR and show some basic trials I've done.

Also, for me to find the difference between the original and modified codes, to make the debugging faster.

@ytdHuang ytdHuang changed the title Introduce Space and Dimensions first try of Space and Dimensions Jan 1, 2025
@ytdHuang ytdHuang marked this pull request as ready for review January 1, 2025 11:02
@ytdHuang ytdHuang changed the base branch from main to dev/dimensions January 1, 2025 11:03
@ytdHuang ytdHuang merged commit d3977c6 into qutip:dev/dimensions Jan 1, 2025
17 of 22 checks passed
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 95.97315% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.00%. Comparing base (270d3f6) to head (2930089).
Report is 16 commits behind head on dev/dimensions.

Files with missing lines Patch % Lines
src/qobj/functions.jl 57.14% 3 Missing ⚠️
src/qobj/quantum_object_base.jl 90.90% 2 Missing ⚠️
src/qobj/arithmetic_and_attributes.jl 96.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (270d3f6) and HEAD (2930089). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (270d3f6) HEAD (2930089)
11 7
Additional details and impacted files
@@                Coverage Diff                 @@
##           dev/dimensions     #359      +/-   ##
==================================================
- Coverage           93.14%   88.00%   -5.15%     
==================================================
  Files                  41       43       +2     
  Lines                2684     2767      +83     
==================================================
- Hits                 2500     2435      -65     
- Misses                184      332     +148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant