Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream #46

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
2 changes: 1 addition & 1 deletion 01_challenge/01_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def fizzbuzz(max_num):
# % or modulo division gives you the remainder
if i%num1==0 and i%num2==0:
print(i,three_mul+five_mul)
elif i%num1=0:
elif i%num1==0:
print(i,three_mul)
elif i%num2==0:
print(i,five_mul)
Expand Down
1 change: 1 addition & 0 deletions 01_challenge/01_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The error was because the assignment operator was '=' instead of '=='
2 changes: 1 addition & 1 deletion 02_challenge/02_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ def fizzbuzz(max_num):

#----START OF SCRIPT
if __name__=='__main__':
fizzbuzz()
fizzbuzz(10)
1 change: 1 addition & 0 deletions 02_challenge/02_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The error was not adding an argument
2 changes: 1 addition & 1 deletion 03_challenge/03_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
def fizzbuzz(max_num):
"This method implements FizzBuzz"
# Google for 'range in python' to see what it does
for i in range(1,max_num):
for i in range(1,int(max_num)):
# % or modulo division gives you the remainder
if i%3==0 and i%5==0:
print(i,"fizzbuzz")
Expand Down
3 changes: 3 additions & 0 deletions 03_challenge/03_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The error was the argument was a string
So i converted that string to an integer
for it to be accepted as an argument for the range....
2 changes: 1 addition & 1 deletion 04_challenge/04_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def fizzbuzz(max_num):
for i in range(1,max_num):
# % or modulo division gives you the remainder
if i%num1==0 and i%num2==0:
print(i,three_mul+five_mul)
print(i,three_mul+five_mul)
elif i%num1==0:
print(i,three_mul)
elif i%num2==0:
Expand Down
1 change: 1 addition & 0 deletions 04_challenge/readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Indentation error
2 changes: 1 addition & 1 deletion 05_challenge/05_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def fizzbuzz(max_num):
three_mul = 'fizz'
five_mul = 'buzz'
with open('mifile.txt','r') as f:
print 'i have created'
print ('i have created')
num1 = int(f.readline())
num2=int(f.readline())
max_num = int(f.readline())
Expand Down
1 change: 1 addition & 0 deletions 05_challenge/05_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ADDED MY OWN FILE.TXT
1 change: 1 addition & 0 deletions 05_challenge/mifile.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
dfjdlfdf;kdj/f/FDJ
2 changes: 1 addition & 1 deletion 06_challenge/06_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def fizzbuzz(max_num):
three_mul = 'fizz'
five_mul = 'buzz'
num1 = conf.num1
num2 = conf.num
num2 = conf.num2
# Google for 'range in python' to see what it does
for i in range(1,max_num):
# % or modulo division gives you the remainder
Expand Down
1 change: 1 addition & 0 deletions 06_challenge/06_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Logical error
6 changes: 3 additions & 3 deletions 08_challenge/08_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
class Fizz_Buzz:
"Class to implement FizzBuzz for multiples of 3 and 5"

def fizzbuzz(max_num):
def fizzbuzz(self,max_num):
"This method implements FizzBuzz"

# adding some redundant declarations on purpose
Expand All @@ -35,6 +35,6 @@ def fizzbuzz(max_num):
#----START OF SCRIPT
if __name__=='__main__':
"Initialize the fizzbuzz object"
fizzbuzz_obj = Fizz_Buzz()
fizzbuzz_obj.fizzbuzz(100)
new_object = Fizz_Buzz()
new_object.fizzbuzz(345)

5 changes: 5 additions & 0 deletions 08_challenge/08_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
First error was adding self to the function

Second error was creating a new instance of the Fizz_Buzz class

Using the new new instance to call the methods
2 changes: 2 additions & 0 deletions 09_challenge/09_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,5 @@ def fizzbuzz(max_num):
#----START OF SCRIPT
if __name__=='__main__':
fizzbuzz(100)


2 changes: 1 addition & 1 deletion 10_challenge/10_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
# print buzz for multiples of 5
# print fizzbuzz for multiples of 3 and 5"
"""
import fizzbuzz
from fizzbuzz import fizzbuzz

#----START OF SCRIPT
if __name__=='__main__':
Expand Down
6 changes: 3 additions & 3 deletions 13_challenge/13_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ def fizzbuzz(max_num):

# adding some redundant declarations on purpose
# we will make our script 'tighter' in one of coming exercises
three_mul = 'fizz
three_mul = 'fizz'
five_mul = 'buzz'
num1 = 3
num2 = 5

# Google for 'range in python' to see what it does
for i in range(1,max_num)
for i in range(1,max_num):
# % or modulo division gives you the remainder
if i%num1==0 and i%num2==0:
print(i,three_mul+five_mul)
Expand All @@ -31,4 +31,4 @@ def fizzbuzz(max_num):

#----START OF SCRIPT
if __name__=='__main__':
fizzbuzzy(100)
fizzbuzz(100)
1 change: 1 addition & 0 deletions 13_challenge/13_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3 syntax errors