Skip to content

Mark R_init_fs as visible #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

Mark R_init_fs as visible #480

merged 3 commits into from
Apr 25, 2025

Conversation

MichaelChirico
Copy link
Contributor

See https://cran.r-project.org/doc/manuals/r-devel/R-exts.html#Controlling-visibility.

As it is, {fs} fails to compile under -fvisibility=hidden.

@jeroen
Copy link
Member

jeroen commented Apr 6, 2025

We should add PKG_CFLAGS=$(C_VISIBILITY) too, such that internal symbols from libuv do not polluate the namespace.

@gaborcsardi gaborcsardi merged commit 7731076 into r-lib:main Apr 25, 2025
20 checks passed
@gaborcsardi
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelChirico @jeroen @gaborcsardi