Add chunk iterator API to osiris_log #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
reviewed
Oct 24, 2023
ansd
approved these changes
Oct 24, 2023
To allow readers to read chunks incrementally rather than in one go. osiris_log:read_chunk_parsed/2 has been updated to use the chunk iterator API as well but with a full chunk read ahead configuration. osiris_log:chunk_iterator/2 tries to estimate a read ahead amount based on the "credit hint" that can be passed to indicate how many entries are likely to be read in one go.
kjnilsson
force-pushed
the
chunk-iterator
branch
from
6113622 to
bdc0848
Compare
For parsing uncompressed batch entries.
acogoluegnes
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow readers to read chunks incrementally rather than in one go.
osiris_log:read_chunk_parsed/2 has been updated to use the chunk iterator API as well but with a full chunk read ahead configuration.
osiris_log:chunk_iterator/2 tries to estimate a read ahead amount based on the "credit hint" that can be passed to indicate how many entries are likely to be read in one go.