-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PMTiles for tileserver. #33
Conversation
Added *a* style file to have something to point at. That needs some work.
✅ Deploy Preview for queeringthemap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Before merging this PR let's finish the styling done in issue #20. The work for that can be done in this branch. |
Credits to Lucas
Should we update the CORS configuration on tiles.queeringthemap.com to allow requests from the deploy previews? Would be good to keep the deploys working with the self-hosted tiles. If so, The deploy preview URLs follow this pattern: @nielsbom, what do you think? |
I actually already tried to do that a while ago, the
But that still blocks the requests. Putting the literal domain, including subdomain in there works, but that's kinda ugly. I think something like this may help but I haven't got that working. |
I created an issue to track the CORS config: #42 |
Once @queeringthemap commits the finished styling json (#20 (comment)), are we good to merge this? I know #50 is open but we can deal with that separately. |
Related: we reached the monthly tile limit of MapTiler's free plan this morning so no more tiles with my API key for a week! |
@jokroese Lucas has added the final style.json file. I've merged main into the branch. Can you review and merge please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work team!
Added a style file to have something to point at. That needs some work.