Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PMTiles for tileserver. #33

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Use PMTiles for tileserver. #33

merged 5 commits into from
Jun 20, 2024

Conversation

nielsbom
Copy link
Collaborator

Added a style file to have something to point at. That needs some work.

Added *a* style file to have something to point at. That needs some
work.
Copy link

netlify bot commented May 17, 2024

Deploy Preview for queeringthemap ready!

Name Link
🔨 Latest commit bbb57bc
🔍 Latest deploy log https://app.netlify.com/sites/queeringthemap/deploys/66647126d62bd800084d4d67
😎 Deploy Preview https://deploy-preview-33--queeringthemap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nielsbom
Copy link
Collaborator Author

Before merging this PR let's finish the styling done in issue #20. The work for that can be done in this branch.

Credits to Lucas
@jokroese
Copy link
Member

jokroese commented May 27, 2024

Should we update the CORS configuration on tiles.queeringthemap.com to allow requests from the deploy previews? Would be good to keep the deploys working with the self-hosted tiles. If so, The deploy preview URLs follow this pattern: https://deploy-preview-<number>--queeringthemap.netlify.app/.

@nielsbom, what do you think?

@nielsbom
Copy link
Collaborator Author

nielsbom commented May 29, 2024

Should we update the CORS configuration on tiles.queeringthemap.com to allow requests from the deploy previews? Would be good to keep the deploys working with the self-hosted tiles. If so, The deploy preview URLs follow this pattern: https://deploy-preview-<number>--queeringthemap.netlify.app/.

I actually already tried to do that a while ago, the ALLOW_ORIGINS setting is now:

http://127.0.0.1:5501,https://maplibre.org,http://localhost:5173,https://netlify.app

But that still blocks the requests.

Putting the literal domain, including subdomain in there works, but that's kinda ugly.

I think something like this may help but I haven't got that working.

@nielsbom
Copy link
Collaborator Author

I created an issue to track the CORS config: #42
I also think it's not a blocking issue right now.

@jokroese jokroese linked an issue Jun 5, 2024 that may be closed by this pull request
@jokroese
Copy link
Member

jokroese commented Jun 6, 2024

Once @queeringthemap commits the finished styling json (#20 (comment)), are we good to merge this? I know #50 is open but we can deal with that separately.

@jokroese
Copy link
Member

jokroese commented Jun 6, 2024

Related: we reached the monthly tile limit of MapTiler's free plan this morning so no more tiles with my API key for a week!

@nielsbom nielsbom requested a review from jokroese June 8, 2024 14:58
@nielsbom
Copy link
Collaborator Author

nielsbom commented Jun 8, 2024

@jokroese Lucas has added the final style.json file. I've merged main into the branch. Can you review and merge please?

@jokroese jokroese merged commit 4a931e9 into main Jun 20, 2024
4 checks passed
@jokroese jokroese deleted the pmtiles branch June 20, 2024 18:22
Copy link
Member

@jokroese jokroese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish Map Styling in Protomaps
2 participants