allow customization of application name in the generated title #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update fixes the `Style/SuperArgument` error from `standardrb`
This update allows users to now pass a custom name instead of using the default value, i.e., the application from `Rails.application.name`.
|
Here's an example of usage.
|
thedumbtechguy
requested changes
Feb 1, 2025
lib/plutonium/core/controller.rb
Outdated
| @@ -29,8 +29,8 @@ def set_page_title(page_title) | |||
| @page_title = page_title | |||
| end | |||
|
|
|||
| def make_page_title(title) | |||
| [title.presence, helpers.application_name].compact.join(" | ") | |||
| def make_page_title(title, app_name: helpers.application_name) | |||
There was a problem hiding this comment.
I would add an app_name method that defaults to helpers.application_name and remove the app_name param from make_page_title altogether.
def make_page_title(title)
[title.presence, app_name].compact.join(" | ")
end
def app_name
helpers.application_name
endThere was a problem hiding this comment.
This is much cleaner. We should have this instead.
thedumbtechguy
approved these changes
Feb 2, 2025
thedumbtechguy
changed the title
make_page_title to Accept An Optional app_name Parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the flexibility and functionality of methods in the
lib/plutoniumdirectory. The most important changes include modifying themake_page_titlemethod to accept an optionalapp_nameparameter and simplifying thesubmit_buttonmethod by removing redundant parameters.Improvements to method parameters:
lib/plutonium/core/controller.rb: Modified themake_page_titlemethod to accept an optionalapp_nameparameter, allowing more flexibility in setting the page title.Code simplification:
lib/plutonium/ui/form/interaction.rb: Simplified thesubmit_buttonmethod by removing redundant parameters, making the code cleaner and easier to maintain.