Skip to content

fixing point light sources for glossy surfaces #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixing point light sources for glossy surfaces #17

wants to merge 2 commits into from

Conversation

chinmay0301ucsd
Copy link

@chinmay0301ucsd chinmay0301ucsd commented Oct 4, 2022 •
edited
Loading

This PR fixes 2 issues -

  1. Potential bug in triangle mesh class  #16
  2. Currently, the glossy surface rendering would only work in presence of directional light in the code. I modified the code for it to work with both directional and point light sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chinmay0301ucsd