Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brendan/animation 2 #57

Open
wants to merge 12 commits into
base: staging
Choose a base branch
from
Open

Brendan/animation 2 #57

wants to merge 12 commits into from

Conversation

feemcgill
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented May 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dot-org-v2 ✅ Ready (Inspect) Visit Preview May 20, 2022 at 8:01PM (UTC)

Copy link
Contributor

@manolingam manolingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deploy is successful and is looking good but there's a few more things that needs to be fixed.

  1. The banner image in manifesto is not centered when going below large screen resolutions. It should be centered.

  2. Also, the main hero banner doesn't appear for mobile screens & is also off the layout when on tab kind of resolutions.

  3. There are a few empty files in the pr which needs to be removed. For example, animation/base/displace.js is empty.

  4. And in the public/animation/img folder, I think there are images that are not used for the animation. Pls remove images that are not used for the animation. For example, our logo isn't animated right? But there are imgs related to it & a few others.

  5. Finally, can you remove the .vscode folder in the pr & add it to .gitignore.

Thank you :))

@feemcgill
Copy link
Member Author

@manolingam Thanks for your review. I've addressed everything and its all reflected here in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants