feat: add support for Rails 7.1 #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoshy
force-pushed
the
rails_7.1
branch
14 times, most recently
from
ea1f51c to
cf65943
Compare
|
is there an update on this one? would be nice to have |
|
The tests are failing on Rails 7.1, but updating to the latest RSpec version seems to make them pass. |
hoshy
force-pushed
the
rails_7.1
branch
6 times, most recently
from
8e2cf9d to
37429dc
Compare
Well, it makes 7.1 pass, but 6.1 and 7.0 are now failing 🤷🏻♂️ |
|
Any news about that? |
| class << self | ||
| def table_exists? | ||
| connection.table_exists?(table_name) | ||
| end | ||
| alias :table_name :name |
There was a problem hiding this comment.
Why this change? I think this is causing problems
Let's continue with yours. But yes, needs some (manual) testing. |
|
closing due to #243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from #233 are included here.