Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix image tag #829

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: Fix image tag #829

wants to merge 1 commit into from

Conversation

yiannistri
Copy link
Contributor

@yiannistri yiannistri commented Jan 15, 2025

What this PR does / why we need it:

When the nightly image tag is set to a big integer i.e. 20250115, helm attempts to convert it to a float64 value so it will end up converting the value to a tag that does not exist. To work around this issue, we set the image tag to v0.0.0-20250115 which helm will treat as a string.

Which issue(s) this PR fixes
Issue #766

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

@yiannistri yiannistri marked this pull request as ready for review January 15, 2025 17:37
@yiannistri yiannistri requested a review from a team as a code owner January 15, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants