Skip to content

feat: use-drawable-chars (part 1) and drop rect usage #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 51 commits into from
Apr 12, 2025
Merged

Conversation

raphamorim
Copy link
Owner

@raphamorim raphamorim commented Feb 22, 2025

Closes #616
Closes #974
Closes #895

                                                                      ▉
  ╔══╦══╗  ┌──┬──┐  ╭──┬──╮  ╭──┬──╮  ┏━━┳━━┓  ┎┒┏┑   ╷  ╻ ┏┯┓ ┌┰┐    ▊ ╱╲╱╲╳╳╳
  ║┌─╨─┐║  │╔═╧═╗│  │╒═╪═╕│  │╓─╁─╖│  ┃┌─╂─┐┃  ┗╃╄┙  ╶┼╴╺╋╸┠┼┨ ┝╋┥    ▋ ╲╱╲╱╳╳╳
  ║│╲ ╱│║  │║   ║│  ││ │ ││  │║ ┃ ║│  ┃│ ╿ │┃  ┍╅╆┓   ╵  ╹ ┗┷┛ └┸┘    ▌ ╱╲╱╲╳╳╳
  ╠╡ ╳ ╞╣  ├╢   ╟┤  ├┼─┼─┼┤  ├╫─╂─╫┤  ┣┿╾┼╼┿┫  ┕┛┖┚     ┌┄┄┐ ╎ ┏┅┅┓ ┋ ▍ ╲╱╲╱╳╳╳
  ║│╱ ╲│║  │║   ║│  ││ │ ││  │║ ┃ ║│  ┃│ ╽ │┃  ░░▒▒▓▓██ ┊  ┆ ╎ ╏  ┇ ┋ ▎
  ║└─╥─┘║  │╚═╤═╝│  │╘═╪═╛│  │╙─╀─╜│  ┃└─╂─┘┃  ░░▒▒▓▓██ ┊  ┆ ╎ ╏  ┇ ┋ ▏
  ╚══╩══╝  └──┴──┘  ╰──┴──╯  ╰──┴──╯  ┗━━┻━━┛  ▗▄▖▛▀▜   └╌╌┘ ╎ ┗╍╍┛ ┋  ▁▂▃▄▅▆▇█
                                               ▝▀▘▙▄▟
PNG image

Before

image

After

image

Before

Screenshot 2025-04-10 at 09 55 42

After

Screenshot 2025-04-10 at 09 56 50
  • Update CascadiaCode to remove Powerline since we know draw
  • Should work well for different dpis
  • Horizontal
  • Vertical
  • HeavyHorizontal
  • HeavyVertical
  • TopRight
  • TopLeft
  • BottomRight
  • BottomLeft
  • Cross
  • VerticalRight
  • VerticalLeft
  • HorizontalDown
  • HorizontalUp
  • ArcTopLeft
  • ArcBottomRight
  • ArcBottomLeft
  • ArcTopRight
  • LowerOneQuarterBlock
  • LowerOneEighthBlock
  • HorizontalLightDash
  • HorizontalHeavyDash
  • HorizontalLightDoubleDash
  • HorizontalHeavyDoubleDash
  • HorizontalLightTripleDash
  • HorizontalHeavyTripleDash
  • VerticalLightDash
  • VerticalHeavyDash
  • VerticalLightDoubleDash
  • VerticalHeavyDoubleDash
  • VerticalLightTripleDash
  • VerticalHeavyTripleDash
  • QuadrantUpperLeft
  • QuadrantUpperRight
  • QuadrantLowerLeft
  • QuadrantLowerRight
  • UpperHalf
  • LowerHalf
  • LeftHalf
  • RightHalf
  • LightShade
  • MediumShade
  • DarkShade
  • FullBlock
  • PowerlineLeftSolid
  • PowerlineRightSolid
  • PowerlineLeftHollow
  • PowerlineRightHollow
  • PowerlineCurvedRightSolid
  • PowerlineCurvedRightHollow
  • PowerlineCurvedLeftSolid
  • PowerlineCurvedLeftHollow

@raphamorim raphamorim changed the title wip: support builtin_box_drawing config wip: support to character ranges, builtin_box_drawing and unicode rendering improvements Feb 22, 2025
@raphamorim raphamorim force-pushed the renderer-fixes branch 2 times, most recently from 9330c71 to 27dfff1 Compare February 24, 2025 20:54
@raphamorim raphamorim force-pushed the main branch 2 times, most recently from 8f38185 to 6f1ea14 Compare February 24, 2025 21:09
@raphamorim raphamorim changed the title wip: support to character ranges, builtin_box_drawing and unicode rendering improvements wip: builtin_box_drawing and unicode rendering improvements Apr 3, 2025
@raphamorim raphamorim requested a review from Copilot April 12, 2025 18:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 68 out of 68 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

rio-backend/src/crosswords/square.rs:187

  • Verify that 'is_none_or' is supported by the minimum Rust toolchain version, as it may not be available in older versions.
&& self.extra.as_ref().is_none_or(|extra| {

@raphamorim raphamorim changed the title wip: builtin_box_drawing and unicode rendering improvements builtin_box_drawing and unicode rendering improvements Apr 12, 2025
@raphamorim raphamorim changed the title builtin_box_drawing and unicode rendering improvements feat: use-drawable-chars (part 1) and drop rect usage Apr 12, 2025
@raphamorim raphamorim merged commit 8ca7690 into main Apr 12, 2025
13 checks passed
@raphamorim raphamorim deleted the renderer-fixes branch April 12, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant