build: don't hard-code pkg-config #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbea
added a commit
to orbea/RMG
that referenced
this pull request
Oct 20, 2024
This was referenced Oct 20, 2024
eli-schwartz
suggested changes
Oct 20, 2024
| # test for essential build dependencies | ||
| ifeq ($(origin PKG_CONFIG), undefined) | ||
| PKG_CONFIG = $(CROSS_COMPILE)pkg-config | ||
| ifeq ($(shell which $(PKG_CONFIG) 2>/dev/null),) |
There was a problem hiding this comment.
Please don't use this. "which" is less likely to be installed than "pkg-config".
"command -v" is a portable (POSIX mandated) equivalent to "which".
There was a problem hiding this comment.
I'll see about improving the check for mupen64plus-core in the near future and then change it here too depending on their response.
|
On second look I didn't do quite enough so I changed the check to better match the current style in mupen64plus-core. |
orbea
added a commit
to orbea/RMG
that referenced
this pull request
Oct 21, 2024
Better matches the style in mupen64plus-core. Upstream-PR: raphnet/mupen64plus-input-raphnetraw#17
Rosalie241
pushed a commit
to Rosalie241/RMG
that referenced
this pull request
Oct 21, 2024
) Better matches the style in mupen64plus-core. Upstream-PR: raphnet/mupen64plus-input-raphnetraw#17
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Oct 21, 2024
Closes: https://bugs.gentoo.org/941889 Upstream-PR: raphnet/mupen64plus-input-raphnetraw#17 Upstream-PR: Rosalie241/RMG#296 Upstream-Commit: Rosalie241/RMG@f6b73b8 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Nov 3, 2024
Closes: https://bugs.gentoo.org/941889 Upstream-PR: raphnet/mupen64plus-input-raphnetraw#17 Upstream-PR: Rosalie241/RMG#296 Upstream-Commit: Rosalie241/RMG@f6b73b8 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Nov 9, 2024
Closes: https://bugs.gentoo.org/941889 Upstream-PR: raphnet/mupen64plus-input-raphnetraw#17 Upstream-PR: Rosalie241/RMG#296 Upstream-Commit: Rosalie241/RMG@f6b73b8 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Nov 9, 2024
Closes: https://bugs.gentoo.org/941889 Upstream-PR: raphnet/mupen64plus-input-raphnetraw#17 Upstream-PR: Rosalie241/RMG#296 Upstream-Commit: Rosalie241/RMG@f6b73b8 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Nov 15, 2024
Closes: https://bugs.gentoo.org/941889 Upstream-PR: raphnet/mupen64plus-input-raphnetraw#17 Upstream-PR: Rosalie241/RMG#296 Upstream-Commit: Rosalie241/RMG@f6b73b8 Signed-off-by: orbea <orbea@riseup.net>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Nov 26, 2024
Closes: https://bugs.gentoo.org/941889 Upstream-PR: raphnet/mupen64plus-input-raphnetraw#17 Upstream-PR: Rosalie241/RMG#296 Upstream-Commit: Rosalie241/RMG@f6b73b8 Signed-off-by: orbea <orbea@riseup.net> Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for distros that set
PKG_CONFIGin the environment. The check was copied frommupen64plus-core.