Skip to content

removing change blocks and some diagram improvements #5231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: branch-25.10
Choose a base branch
from
Open

removing change blocks and some diagram improvements #5231

wants to merge 11 commits into from

Conversation

acostadon
Copy link
Contributor

resolves #5181

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 15, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@acostadon acostadon self-assigned this Aug 15, 2025
@acostadon acostadon added non-breaking Non-breaking change Notebook doc Documentation labels Aug 15, 2025
@acostadon acostadon marked this pull request as ready for review August 15, 2025 16:39
@acostadon acostadon requested review from a team as code owners August 15, 2025 16:39
@acostadon acostadon requested a review from rlratzel August 15, 2025 16:39
@acostadon acostadon changed the title removing change blocks and copyrights also some diagram improvements removing change blocks and some diagram improvements Aug 19, 2025
@BradReesWork
Copy link
Member

you should update the NetworkX sections to also use the same Karate datafile.

Read the data, this also created a NetworkX Graph

datafile = karate.get_path()
file = open(datafile, 'rb')
Gnx = nx.read_edgelist(file, nodetype=int, data=(("weight", float),))

BradReesWork
BradReesWork requested changes Aug 20, 2025
View reviewed changes
BradReesWork
BradReesWork requested changes Aug 21, 2025
View reviewed changes
Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You need to clear output on Force-Atlas2
  • similarity_combined - the copyright should be a range
  • notebooks/cugraph_benchmarks/pagerank_benchmark.ipynb - needs copyright updated

notebooks/algorithms/link_prediction/similarity_combined.ipynb Outdated
@@ -184,7 +179,7 @@
"metadata": {},
"source": [
"----\n",
"Copyright (c) 2023, NVIDIA CORPORATION.\n",
"Copyright (c) 2025, NVIDIA CORPORATION.\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Copyright (c) 2025, NVIDIA CORPORATION.\n",
"Copyright (c) 2023-2025, NVIDIA CORPORATION.\n",

@BradReesWork BradReesWork mentioned this pull request Aug 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@rlratzel rlratzel Awaiting requested review from rlratzel rlratzel is a code owner automatically assigned from rapidsai/cugraph-notebook-codeowners

Assignees

@acostadon acostadon

Labels
doc Documentation non-breaking Non-breaking change Notebook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up notebook changelogs
2 participants
@acostadon @BradReesWork