Update logistic regression test threshold #6487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
reviewed
Mar 26, 2025
| @@ -693,7 +693,7 @@ def test_logistic_regression_model_digits( | |||
| # smallest sklearn score with max_iter = 10000 | |||
| # put it as a constant here, because sklearn 0.23.1 needs a lot of iters | |||
| # to converge and has a bug returning an unrelated error if not converged. | |||
| acceptable_score = 0.95 | |||
| acceptable_score = 0.94 | |||
There was a problem hiding this comment.
How about lowering this even more? Mostly to avoid us coming here again in the future to lower it to 0.93, and then a few months later again, etc.
Maybe something like 0.90 is good enough to detect that "things broadly work" and would make it very unlikely that we get unlucky and see it fluctuate down. I assume this test is more of a smoke test/check that things generally work. Not one that checks that there are no bugs in the algorithm's implementation.
csadorf
approved these changes
Apr 16, 2025
csadorf
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the
test_logistic_regression_model_digitsis making the CI fail intermittently. This change lowers the thresholdfor the test. Please tell me if you think that it is a genuine test failure that happens because of a recent change.
See failure here.