-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(conda): enable strict channel priority for conda build #674
base: branch-25.06
Are you sure you want to change the base?
Conversation
It isn't going to be possible to use I'll have to update the build scripts to not set strict priority for 11.8 builds on x86_64 |
I think I'm going to hold off on those for a follow-up, because it's also going to involve removing channels from |
In that case, could you please note this in the OP of issue ( rapidsai/build-planning#84 )? Since it sounds like we need two passes of all RAPIDS projects to implement this, would also update the checklist to reflect this is part 1 |
# Remove `rapidsai` channel for non-release builds | ||
if ! rapids-is-release-build; then | ||
conda config --remove channels rapidsai | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not terribly important, but this boilerplate seems like it could be added to a function in gha-tools to reduce the copy-paste stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, strong agree -- I have a draft PR open for that here rapidsai/gha-tools#153 but I didn't want to merge it in mid-release.
I think I'm going to hold off on any more channel priority PRs until I can change things more easily.
This is waiting for rapidsai/gha-tools#153, which is waiting until after the 25.04 release. |
This PR enables strict channel priority for building conda packages with
conda-build
.xref rapidsai/build-planning#84