Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(conda): enable strict channel priority for conda build #674

Open
wants to merge 5 commits into
base: branch-25.06
Choose a base branch
from

Conversation

gforsyth
Copy link
Contributor

This PR enables strict channel priority for building conda packages with conda-build.

xref rapidsai/build-planning#84

@gforsyth gforsyth requested a review from a team as a code owner March 21, 2025 17:58
@gforsyth gforsyth added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 21, 2025
@gforsyth gforsyth requested a review from raydouglass March 21, 2025 17:58
@gforsyth
Copy link
Contributor Author

It isn't going to be possible to use strict priority with some cuda11 builds because of libcufile versions spread across conda-forge and nvidia (newer version are all available on conda-forge but older versions are only on nvidia).

I'll have to update the build scripts to not set strict priority for 11.8 builds on x86_64

@jakirkham
Copy link
Member

jakirkham commented Mar 25, 2025

Thanks Gil! 🙏

Do we need similar changes for testing?

rapids-mamba-retry env create -qy -f env.yaml -n test

rapids-mamba-retry env create -qy -f env.yaml -n test

Edit: And doc builds?

rapids-mamba-retry env create -yq -f env.yaml -n docs

@gforsyth
Copy link
Contributor Author

I think I'm going to hold off on those for a follow-up, because it's also going to involve removing channels from dependencies.yaml and some changes upstream in gha-tools

@jakirkham
Copy link
Member

In that case, could you please note this in the OP of issue ( rapidsai/build-planning#84 )?

Since it sounds like we need two passes of all RAPIDS projects to implement this, would also update the checklist to reflect this is part 1

# Remove `rapidsai` channel for non-release builds
if ! rapids-is-release-build; then
conda config --remove channels rapidsai
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not terribly important, but this boilerplate seems like it could be added to a function in gha-tools to reduce the copy-paste stuff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, strong agree -- I have a draft PR open for that here rapidsai/gha-tools#153 but I didn't want to merge it in mid-release.
I think I'm going to hold off on any more channel priority PRs until I can change things more easily.

@bdice
Copy link
Contributor

bdice commented Mar 31, 2025

This is waiting for rapidsai/gha-tools#153, which is waiting until after the 25.04 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants