Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port all conda recipes to rattler-build #678

Merged
merged 23 commits into from
Apr 7, 2025

Conversation

gforsyth
Copy link
Contributor

@gforsyth gforsyth commented Apr 1, 2025

Port all condabuild recipes over to use rattler-build instead.

Contributes to rapidsai/build-planning#47

  • To satisfy rattler-build, this changes all the licenses in the pyproject.toml files to the SPDX-compliant Apache-2.0 instead of Apache 2.0

@gforsyth gforsyth added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Apr 1, 2025
Copy link

copy-pr-bot bot commented Apr 1, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@gforsyth
Copy link
Contributor Author

gforsyth commented Apr 1, 2025

/ok to test

@gforsyth
Copy link
Contributor Author

gforsyth commented Apr 1, 2025

/ok to test

@gforsyth gforsyth marked this pull request as ready for review April 1, 2025 19:18
@gforsyth gforsyth requested review from a team as code owners April 1, 2025 19:18
@gforsyth gforsyth requested a review from AyodeAwe April 1, 2025 19:18
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tacking on my changes from #656 into this PR. Please take these suggestions with a grain of salt -- I haven't fully validated them, and there may be some gray area here where we need to support libcufile on ARM and are willing to accept some minor issues on CUDA 12.0/12.1 in order to get the benefits of libcufile on CUDA 12.2+.

Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@gforsyth
Copy link
Contributor Author

gforsyth commented Apr 2, 2025

This is the same failure I was seeing before:

=========================== short test summary info ============================
FAILED tests/test_cufile_driver.py::test_open_and_close - RuntimeError: KvikIO failure at: /tmp/conda-bld-output/bld/rattler-build_libkvikio/work/cpp/src/shim/cufile.cpp:99: KvikIO not compiled with cuFile.h
FAILED tests/test_cufile_driver.py::test_property_accessor - RuntimeError: KvikIO failure at: /tmp/conda-bld-output/bld/rattler-build_libkvikio/work/cpp/src/cufile/driver.cpp:181: KvikIO not compiled with cuFile.h
= 2 failed, 1350 passed, 105 skipped, 10 xfailed, 2 xpassed in 71.12s (0:01:11) =

On the arm job testing against cuda 12.0.1

So I think I'll revert the linux64 changes to keep parity with the existing recipe for now, although I would love to not deal with the nvidia channel

@gforsyth
Copy link
Contributor Author

gforsyth commented Apr 2, 2025

Hey @bdice -- I think I've got a reasonable compromise in-place here if you want to take a look

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the specific concerns I had about libcufile on ARM. Sticking to the status quo for now and revisiting later seems like the best we can do.

@gforsyth
Copy link
Contributor Author

gforsyth commented Apr 7, 2025

/merge

@rapids-bot rapids-bot bot merged commit 2c2357a into rapidsai:branch-25.06 Apr 7, 2025
63 checks passed
@gforsyth gforsyth deleted the rattler-build branch April 7, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants