fix(blade): page gets scrolled to top on iOS on bottomsheet open #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 11935b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 11935b1:
|
BundleMonFiles updated (1)
Unchanged files (13)
Total files change -568B -0.09% Final result: ✅ View report in BundleMon website ➡️ |
anuraghazra
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
dhruvdutt,
nashcheez,
divyanshu013,
saurabhdaware and
snitin315
as code owners
|
✅ PR title follows Conventional Commits specification. |
snitin315
previously approved these changes
Dec 4, 2023
saurabhdaware
approved these changes
Dec 4, 2023
anuraghazra
added a commit
that referenced
this pull request
Apr 9, 2024
* fix(blade): page gets scrolled to top on iOS on bottomsheet open * Create fluffy-chicken-hunt.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1860
There's a bug in the body-scroll-lock packages which causes iOS mobile to scroll to the top when bottomsheet opens.
willmcpo/body-scroll-lock#237
I've updated the lib with the community fixed version.
And also updated the storybook canvas to NOT use absolute positioning while rendering the stories which causes issues because this is not how most consumers use our components.