Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass array item to lens map callback #10

Merged
merged 12 commits into from
Mar 19, 2025
Merged

feat: pass array item to lens map callback #10

merged 12 commits into from
Mar 19, 2025

Conversation

aspirisen
Copy link
Collaborator

I decided to pass real array value in map callback to remove keyName argument.
Looks like there is no way to avoid passing fields to map method, so then I think it is fine to pass array item in callback and let user to decide what should be used in key prop in jsx

@aspirisen aspirisen self-assigned this Mar 11, 2025
@aspirisen aspirisen requested a review from bluebill1049 March 11, 2025 21:17
@aspirisen aspirisen mentioned this pull request Mar 12, 2025
Base automatically changed from remove-join-method to main March 15, 2025 14:43
Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aspirisen aspirisen merged commit 84e5a47 into main Mar 19, 2025
5 checks passed
Copy link

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants