-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement typed Input/Output interface for resolvers #753
base: dev
Are you sure you want to change the base?
Conversation
@jorisre I believe I made some progress on the types here, in #755 and in react-hook-form/react-hook-form#12664 Let me know how it looks to you |
80df41d
to
75f0f69
Compare
I need some help fixing this TS issue. @bluebill1049 @controversial or @kotarella1110 ![]() |
Size Change: +1.72 kB (+3.17%) Total Size: 55.8 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Appreciate your hard work!
Appreciate your help, thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone! Huge effort @jorisre
This PR implements typed Input/Output interfaces for resolvers, which needs react-hook-form/react-hook-form#12638
Next steps will involve extending this implementation to all applicable resolver modules.
Note: This PR will fail until the release of react-hook-form/react-hook-form#12638
Fixes #743