ci: publish docker image after new release #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #409 +/- ##
=======================================
Coverage 47.78% 47.78%
=======================================
Files 17 17
Lines 1149 1149
=======================================
Hits 549 549
Misses 600 600 |
mdonadoni
force-pushed
the
release-docker
branch
from
f5f75e0 to
92a56b6
Compare
tiborsimko
reviewed
Nov 10, 2023
| @@ -5,3 +5,4 @@ | |||
| # under the terms of the MIT License; see LICENSE file for more details. | |||
|
|
|||
| paramiko[gssapi]==3.0.0 | |||
| gssapi==1.6.1 | |||
There was a problem hiding this comment.
Tested on Slurm and everything was OK with downgraded gssapi version. Paramiko dependencies allow this, so we can pin the version indeed.
mdonadoni
force-pushed
the
release-docker
branch
from
92a56b6 to
723d24c
Compare
tiborsimko
approved these changes
Nov 10, 2023
mdonadoni
force-pushed
the
release-docker
branch
from
723d24c to
90fffa6
Compare
tiborsimko
reviewed
Nov 10, 2023
.github/workflows/ci.yml
Outdated
| github.event_name == 'push' && | ||
| startsWith(github.ref, 'refs/tags/') | ||
| needs: | ||
| - lint-shellcheck |
There was a problem hiding this comment.
Cosmetics: let's capitalise the "name" as in "Release Docker image" for consistency with the other rules we have, and let's order the "needs" alphabetically.
mdonadoni
force-pushed
the
release-docker
branch
from
90fffa6 to
bd774e3
Compare
Downgrade gssapi in order to use pre-built Ubuntu package to save some time when building the docker image.
mdonadoni
force-pushed
the
release-docker
branch
from
bd774e3 to
6a2abcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana#752