Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): update vomsproxy fallback image #475

Closed
wants to merge 1 commit into from

Conversation

Alputer
Copy link
Member

@Alputer Alputer commented Nov 22, 2024

No description provided.

@Alputer Alputer self-assigned this Nov 22, 2024
@Alputer Alputer changed the title fix(config): update vomsproxy fallback image (#475) fix(config): update vomsproxy fallback image Nov 22, 2024
mdonadoni added a commit that referenced this pull request Nov 22, 2024
Make sure the secret key is propagated to the Flask app, instead of
incorrectly using the default one.
mdonadoni pushed a commit that referenced this pull request Nov 22, 2024
Configure the security context of Kubernetes jobs to disallow privilege
escalation.
mdonadoni pushed a commit that referenced this pull request Nov 22, 2024
Configure the security context of Kubernetes jobs to disallow privilege
escalation.
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.07%. Comparing base (6cf4fc0) to head (b975c05).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #475   +/-   ##
=======================================
  Coverage   48.07%   48.07%           
=======================================
  Files          17       17           
  Lines        1302     1302           
=======================================
  Hits          626      626           
  Misses        676      676           
Files with missing lines Coverage Δ
reana_job_controller/config.py 100.00% <ø> (ø)
---- 🚨 Try these New Features:

@@ -66,7 +66,7 @@


VOMSPROXY_CONTAINER_IMAGE = os.getenv(
"VOMSPROXY_CONTAINER_IMAGE", "docker.io/reanahub/reana-auth-vomsproxy:1.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: ‏This PR is not really needed, since upgrade to 1.3.0 is already done on the maint-0.9 branch, and will come to the master branch during maint-to-master upstream merge. Let's rather do that, since it'll bring PUNCH backend support etc.

@Alputer
Copy link
Member Author

Alputer commented Nov 22, 2024

Duplicate of #466.

@Alputer Alputer closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants