Skip to content

Commit

Permalink
fix github happy path
Browse files Browse the repository at this point in the history
  • Loading branch information
nilgaar authored and zdrapela committed Jan 14, 2025
1 parent 0e62cf8 commit 1e128b6
Showing 1 changed file with 15 additions and 13 deletions.
28 changes: 15 additions & 13 deletions e2e-tests/playwright/e2e/github-happy-path.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ test.describe.serial('GitHub Happy path', () => {
await uiHelper.openSidebar('Catalog');
await uiHelper.selectMuiBox('Kind', 'Component');
await uiHelper.clickByDataTestId('user-picker-all');
await uiHelper.clickLink('Backstage Showcase');
await uiHelper.clickLink('test-entity');
await common.clickOnGHloginPopup();
await uiHelper.verifyLink('Janus Website', { exact: false });
await backstageShowcase.verifyPRStatisticsRendered();
Expand Down Expand Up @@ -139,18 +139,20 @@ test.describe.serial('GitHub Happy path', () => {
await backstageShowcase.verifyPRRows(allPRs, lastPagePRs - 5, lastPagePRs);
});

//FIXME
test.skip('Verify that the 5, 10, 20 items per page option properly displays the correct number of PRs', async () => {
await uiHelper.openSidebar('Catalog');
await uiHelper.clickLink('Backstage Showcase');
await common.clickOnGHloginPopup();
await uiHelper.clickTab('Pull/Merge Requests');
await uiHelper.clickButton('ALL', { force: false });
const allPRs = await BackstageShowcase.getShowcasePRs('all');
await backstageShowcase.verifyPRRowsPerPage(5, allPRs);
await backstageShowcase.verifyPRRowsPerPage(10, allPRs);
await backstageShowcase.verifyPRRowsPerPage(20, allPRs);
});
test.fixme(
'Verify that the 5, 10, 20 items per page option properly displays the correct number of PRs',
async () => {
await uiHelper.openSidebar('Catalog');
await uiHelper.clickLink('test-entity');
await common.clickOnGHloginPopup();
await uiHelper.clickTab('Pull/Merge Requests');
await uiHelper.clickButton('ALL', { force: false });
const allPRs = await BackstageShowcase.getShowcasePRs('all');
await backstageShowcase.verifyPRRowsPerPage(5, allPRs);
await backstageShowcase.verifyPRRowsPerPage(10, allPRs);
await backstageShowcase.verifyPRRowsPerPage(20, allPRs);
},
);

test('Verify that the CI tab renders 5 most recent github actions and verify the table properly displays the actions when page sizes are changed and filters are applied', async () => {
await uiHelper.clickTab('CI');
Expand Down

0 comments on commit 1e128b6

Please sign in to comment.